search

mlcommons / training

Reference implementations of MLPerf™ training benchmarks
https://mlcommons.org/en/groups/training
Apache License 2.0
1.57k stars 549 forks source link

Fix outdated RNN-T Dockerfile #586

Closed mikolajblaz closed 1 year ago

mikolajblaz commented 1 year ago

RNN-T docker image stopped building because of an outdated APT repository and new protobuf package issues. This PR fixes that.

github-actions[bot] commented 1 year ago

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

johntran-nv commented 1 year ago

@mikolajblaz could you work with membership to get your git handle added to the CLA? You likely have to fill out the CLA form here: https://mlcommons.org/en/get-involved/. Since your company has already signed, it should be a fast approval.

johntran-nv commented 1 year ago

@mikolajblaz any luck getting yourself added to the CLA list so we can merge this?

mikolajblaz commented 1 year ago

recheck

mikolajblaz commented 1 year ago

@mikolajblaz any luck getting yourself added to the CLA list so we can merge this?

@johntran-nv I just did, I guess we can proceed. Please let me know if you can approve this PR which will re-trigger the checks. I will push some dummy commit otherwie.

johntran-nv commented 1 year ago

@mikolajblaz I approved but it didn't trigger a recheck. could you try to re-trigger it, please? I couldn't, from my side.

mikolajblaz commented 1 year ago

recheck

mikolajblaz commented 1 year ago

Pushing an empty commit did the job. @johntran-nv ready to merge