search

mlcommons / training

Reference implementations of MLPerf™ training benchmarks
https://mlcommons.org/en/groups/training
Apache License 2.0
1.62k stars 560 forks source link

[SD] log number of samples instead of number of iterations #699

Closed ahmadki closed 8 months ago

ahmadki commented 9 months ago

This PR along with https://github.com/mlcommons/logging/pull/357 should address https://github.com/mlcommons/logging/issues/351

github-actions[bot] commented 9 months ago

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

ahmadki commented 9 months ago

The PR is ready, however I'm keeping the WIP tag as I'll need to update logging library in the requirements file after https://github.com/mlcommons/logging/pull/357 is merged

itayhubara commented 9 months ago

Looks good. We should notify the submitters that they might need to change their scripts from the last round to pass the checker.