search

mlcommons / training_policies

Issues related to MLPerf™ training policies, including rules and suggested changes
https://mlcommons.org/en/groups/training
Apache License 2.0
92 stars 66 forks source link

packing rule update #418

Closed mrinaliyer closed 3 years ago

mrinaliyer commented 3 years ago

@johntran-nv @bitfort Please have a look

mrinaliyer commented 3 years ago

@johntran-nv Is this ready to check in?

github-actions[bot] commented 3 years ago

MLCommons CLA bot:
Thank you for your submission, we really appreciate it. We ask that you all sign our MLCommons CLA and be a member before we can accept your contribution. If you are interested in membership, please contact membership@mlcommons.org .
0 out of 2 committers have signed the MLCommons CLA.
:x: @Mrinal Iyer
:x: @mrinaliyer
Mrinal Iyer seems not to be a GitHub user. You need a GitHub account after you become MLCommons member. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

guschmue commented 3 years ago

recheck

guschmue commented 3 years ago

recheck

guschmue commented 3 years ago

The cla bot is complaining:

Found following users in PR who have not signed CLA: (Mrinal Iyer, )

Basically in your first of 2 commits in this PR the user is not a github user, more like a local user. You can fix this via git commit --amend

johntran-nv commented 3 years ago

Hi @mrinaliyer , when I've had this problem in other PR's, the easiest solution I've had is to just create a brand new PR after making the local git user changes. Or even easier, you can just use the web interface for rules changes like this.

mrinaliyer commented 3 years ago

Thanks for the tip! I'll do that

On Mon, Apr 26, 2021 at 9:02 PM johntran-nv @.***> wrote:

Hi @mrinaliyer https://github.com/mrinaliyer , when I've had this problem in other PR's, the easiest solution I've had is to just create a brand new PR after making the local git user changes. Or even easier, you can just use the web interface for rules changes like this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mlcommons/training_policies/pull/418#issuecomment-827296491, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABB363VGYK5IOTQYKHFM5K3TKYZOZANCNFSM4WGPW2IA .

-- Mrinal Iyer, Ph.D. AI Applications Specialist Graphcore

mrinaliyer commented 3 years ago

opening fresh PR