search

mlcommons / training_policies

Issues related to MLPerf™ training policies, including rules and suggested changes
https://mlcommons.org/en/groups/training
Apache License 2.0
92 stars 66 forks source link

Packing rule updates #446

Closed mrinaliyer closed 3 years ago

github-actions[bot] commented 3 years ago

MLCommons CLA bot:
Thank you for your submission, we really appreciate it. We ask that you sign our MLCommons CLA and be a member before we can accept your contribution. If you are interested in membership, please contact membership@mlcommons.org .
0 out of 1 committers have signed the MLCommons CLA.
:x: @Mrinal Iyer
Mrinal Iyer seems not to be a GitHub user. You need a GitHub account after you become MLCommons member. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

mrinaliyer commented 3 years ago

@guschmue Could you advise how to get past the cla-bot? I have amended the commit with the correct email id. No avail :(

guschmue commented 3 years ago

So cla bot complains about

Found following users in PR who have not signed CLA: (Mrinal Iyer, )

I think you need to configure your local git use mrinaliyer

mrinaliyer commented 3 years ago

recheck

mrinaliyer commented 3 years ago

@guschmue I amended my commit with a

git commit --amend --author="mrinaliyer <mrinali@graphcore.ai>"

This fails, so is there anything else I should do?

guschmue commented 3 years ago

recheck

guschmue commented 3 years ago

This looks good but something is still wrong. You can see this when you click on 'Commits' above and hover over the commit author name ... github does not detect it as github handle. I don't see what is wrong. @sub-mod, any thought?