search

mldbai / mldb

MLDB is the Machine Learning Database
http://mldb.ai
Apache License 2.0
663 stars 102 forks source link

MLDB-2105 sql square bracket enh + test update #836

Open FinchPowers opened 7 years ago

mathieumb commented 7 years ago

+1 with some hesitation... now the bracket operator will mean slightly different things when whats on the left is an identifier and when its not. When its an identifier, it'll only select a column from it. When its any row expression on the left, it'll allow evaluation of an expression in the context of that row expression.

FinchPowers commented 7 years ago

@jeremybarnes What do you think?

jeremybarnes commented 7 years ago

I think that this needs to be thought through more. We're now making the . an operator that can be used anywhere; I think it's unclear what the precedence is and how it interacts with other lexical constructs that include dots. To me, [] and . are different constructs syntactically, it just so happens that . is implemented in terms of []. Let's keep the code cleanup, and do a whiteboard session on the semantics.