search

mldbai / mldb

MLDB is the Machine Learning Database
http://mldb.ai
Apache License 2.0
666 stars 102 forks source link

MLDB-2139 plugin dependencies #842

Closed FinchPowers closed 7 years ago

FinchPowers commented 7 years ago

If someone has any ideas on how to test this, I'm opened to suggestions.

FinchPowers commented 7 years ago

Major path bug found. Will fix.

jeremybarnes commented 7 years ago

My feeling is that this would be much cleaner if we simply added a "require" function for the dependencies, that was called when loading. For example, in the main plugin script we would write

mldb.require('tensorflow')

which would then load up the given plugin if it wasn't already loaded. It keeps it declarative, and allows us to avoid having huge lists of hardcoded dependencies which brings in the kitchen sink every time.

In the redesign of the Python plugin system, we could do something similar: eg mldb.pythonRequires('pippackagename >0.34')