mldbai / mldb

MLDB is the Machine Learning Database
http://mldb.ai
Apache License 2.0
666 stars 102 forks source link

Fix wrong implementation of rowLength for embeddings #843

Closed mathieumb closed 7 years ago

mathieumb commented 7 years ago

Fix wrong implementation of rowLength for embeddings and implement getAtomCount.

rowLength is meant to return the number of columns in the first structured level, and that worked for row representations. However for embeddings representations is was returning the number of atoms.

If you need the total number of atoms, the proper method is getAtomCount.

FinchPowers commented 7 years ago

Test to avoid regression?

mathieumb commented 7 years ago

@FinchPowers I had to change from rowLength to getAtomCount in a bunch of places, so now both are tested by dozens of tests.

mathieumb commented 7 years ago

verbal +1 !