MLDB-2193 import text optimizations

mldbai / mldb

MLDB is the Machine Learning Database

http://mldb.ai

Apache License 2.0

661 stars 102 forks source link

MLDB-2193 import text optimizations #890

Closed jeremybarnes closed 7 years ago

jeremybarnes commented 7 years ago

Several micro-optimizations that between them allow for roughly doubling the speed of the import.text procedure.

Test coverage on these is pretty extensive on existing tests.

jeremybarnes commented 7 years ago

Failing test is already on master.

jeremybarnes commented 7 years ago

@FinchPowers test coverage was addressed in the description. I will fix the indentation. I don't think we should make the other changes. Anything else?

FinchPowers commented 7 years ago

Pray proceed. :)