search

mlebjerg / MemeMarketSignals

GNU Affero General Public License v3.0
10 stars 4 forks source link

First contribution #1

Closed EONRaider closed 2 years ago

EONRaider commented 2 years ago

A lot was done to the files, but not much was modified in terms of functionality. Most modifications are related to code quality and formatting.

The one major difference is the removal of the .conf file. When dealing with credentials, when it comes to best-practices, you should pass all the necessary information as environment variables to the application. I did not modify the instructions on the README.md file yet, but it can be done in the future. This implementation should make things easier. The necessary variables are WEBULL_USER and WEBULL_PASS. This will serve well in the future when we use Docker.

Also, could you create a dev branch just so I can avoid pushing new PRs to main in the future?

mlebjerg commented 2 years ago

Love this! You really cleaned up the mess! I am not entirely ready to give up the .conf file yet as it is an easy way to set these two things and one of the standard practice for Docker. Would you mind bringing this back for the time being? Then this can go into main!

I will make a dev branch after this comment

mlebjerg commented 2 years ago

I changed the branch to dev, that way i can merge this now, and we can work on it.