mledoze / countries

World countries in JSON, CSV, XML and Yaml. Any help is welcome!
https://mledoze.github.io/countries/
Open Data Commons Open Database License v1.0
5.98k stars 1.27k forks source link

Hong Kong is not a country #348

Closed luoying1105 closed 5 years ago

luoying1105 commented 5 years ago

Hong Kong is not a country

yackermann commented 5 years ago

Honk Kong is an autonomous territory that is recognised by UN as a self governing territory.

So from our point of view its a country.

On Wed, 14 Aug 2019 at 11:22, luo ying notifications@github.com wrote:

Hong Kong is not a country

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mledoze/countries/issues/348?email_source=notifications&email_token=AAMPOFAMMCQ57DFYNYPSET3QEPMGVA5CNFSM4ILTKXEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HFFLVUQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMPOFBWL2X2YP222WSXZ3LQEPMGVANCNFSM4ILTKXEA .

-- Yuriy Ackermann FIDO, Identity, Standards skype: ackermann.yuriy github: @herrjemand https://github.com/herrjemand twitter: @herrjemand https://twitter.com/herrjemand medium: @herrjemand https://medium.com/@herrjemand

nobodxbodon commented 5 years ago

Indeed it's not a country. The independent attribute is "false" in the json file.

Similar with Macau and Taiwan (its official name "Republic of China (Taiwan)" is totally another issue to discuss about).

That said, the project name and countries.json file name seem quite misleading to me, as it sounds like all the entities included in the data are considered as countries. There are a lot other entities in the list with "independent": false, like Antarctica.

yackermann commented 5 years ago

Honk Kong is self governing territory under special agreement with PRC, same as Tonga has with NZ. HK has it's own Goverment. Manage's it's own affairs. It's own passport, olympics team, etc. HK as of right now is a country. You are free to ping us in 2047 when the agreement between PRC and HK will finish and HK will integrate as part of china. We will be happy to update our DB then

Propose closing it without action.

nobodxbodon commented 5 years ago

I'd suggest not taking too much personal view into this project. As the project states, it's based on ISO Standard 3166-1, which "defines codes for the names of countries, dependent territories, and special areas of geographical interest" (see wiki). So it's better to avoid misleading users to think all the entities in it are countries.

tonyhhyip commented 5 years ago

Hong Kong is allowed to be treated as a country according to the Basic Law, so maybe @nobodxbodon should open the issue after 2047 or the Chinazi government decide to break their promise

mledoze commented 5 years ago

Indeed it's not a country. The independent attribute is "false" in the json file. That said, the project name and countries.json file name seem quite misleading to me, as it sounds like all the entities included in the data are considered as countries. There are a lot other entities in the list with "independent": false, like Antarctica.

Agreed. I will update the README to clarify this.

mledoze commented 5 years ago

Here it is: https://github.com/mledoze/countries/blob/2d5d74b92c17dfe93ddcff78833f15e0e4d35db8/README.md

adamazing commented 5 years ago

s/sovereing/sovereign/ :)

mledoze commented 5 years ago

Ahah good catch 🙂 It's fixed https://github.com/mledoze/countries/commit/4142b1afc4e7a470a493ad48943be850bee85502