search

mledoze / countries

World countries in JSON, CSV, XML and Yaml. Any help is welcome!
https://mledoze.github.io/countries/
Open Data Commons Open Database License v1.0
5.97k stars 1.27k forks source link

UN member states boolean flag #401

Closed rkorzeniec closed 4 years ago

rkorzeniec commented 4 years ago

Added unMember boolean flag. Currently there are 193 (according to wikipedia + un offcial website, this leaves the other 57 states having the flag set to false

rkorzeniec commented 4 years ago

@mledoze friendly ping 😉

mledoze commented 4 years ago

Hello @rkorzeniec, I'm sorry for the delay, you know life, the quarantine and everything else...

I'll look into your pull request this week. Thank you for your work!

Meanwhile could you please add en entry in the changelog?

mledoze commented 4 years ago

The PR looks good. I just need the entry in the changelog before merging it.

rkorzeniec commented 4 years ago

@mledoze I totally understand, I was just worried that you abandoned it a bit, sine the other PRs haven't got much attention either in some time. I will go right ahead with the changelog. Would you like me to add it to unreleased section or create 4.1.0 section?

rkorzeniec commented 4 years ago

I added it to unreleased section for the time being. Much appreciated.

mledoze commented 4 years ago

It's merged, thank you for your work.

rkorzeniec commented 4 years ago

you're welcome 😉