search

mleibman / SlickGrid

A lightning fast JavaScript grid/spreadsheet
http://wiki.github.com/mleibman/SlickGrid
MIT License
6.81k stars 1.98k forks source link

Example 3a compound editors possible error in conditional #1098

Open Codeguyross opened 8 years ago

Codeguyross commented 8 years ago

In the this.isValueChanged function, should the args.item.to be comparing against the $to.val() instead of the $from.val()

In the code: this.isValueChanged = function () { return args.item.from != parseInt($from.val(), 10) || args.item.to != parseInt($from.val(), 10); };

Proposed changed: this.isValueChanged = function () { return args.item.from != parseInt($from.val(), 10) || args.item.to != parseInt($to.val(), 10); };

6pac commented 8 years ago

Good catch! Have made the change to my 'Alternate Master' repo: https://github.com/6pac/SlickGrid/wiki