search

mleibman / SlickGrid

A lightning fast JavaScript grid/spreadsheet
http://wiki.github.com/mleibman/SlickGrid
MIT License
6.81k stars 1.97k forks source link

the onRowCountChanged event does not fire when the data row is 0 #1189

Closed bthachdev closed 6 years ago

bthachdev commented 6 years ago

If we delete an only item in the grid, the onRowCountChange does not fire.

Maybe problem is in these code in slick.dataview.js ? What if rows.length is 0 and countBefore is 0 after we delete an item.

if (countBefore != rows.length) { onRowCountChanged.notify({previous: countBefore, current: rows.length}, null, self); }

6pac commented 6 years ago

Note that the event is only called in refresh() - are you calling it?

Also note this repo is now unmaintained - see slickgrid.net for more details.

bthachdev commented 6 years ago

yes, I called it.

6pac commented 6 years ago

what example are you using to reproduce the behaviour?

bthachdev commented 6 years ago

The issue happen in our code, not in slickgrid library. So I close this.