mleibman / SlickGrid

A lightning fast JavaScript grid/spreadsheet
http://wiki.github.com/mleibman/SlickGrid
MIT License
6.81k stars 1.98k forks source link

Expand group bug #953

Open mkkim417 opened 10 years ago

mkkim417 commented 10 years ago

http://mleibman.github.io/SlickGrid/examples/example-grouping

First, click 'Group by duration & sort groups by value ' button and then, click 'Collapse all groups'

and Try to expand last second group.

last group title rows doesn't disappeared.

danjger commented 10 years ago

I see this issue and here is an easy way to reproduce. visit: http://mleibman.github.io/SlickGrid/examples/example-grouping Click 50k rows Click Collapse all groups Expand Top section (Duration 0) and scroll down to see a spurious header for another grouping

They appear in just about every group but a little father down when you have enough entries in a single group.

danjger commented 10 years ago

ok I saw another but report just like this one: https://github.com/mleibman/SlickGrid/issues/841 I deployed the users suggested fix and it seems to take care of the issue: https://github.com/icoxfog417/SlickGrid/pull/3

diff --git a/slick.groupitemmetadataprovider.js b/slick.groupitemmetadataprovider.js
index c40551c..55d40bc 100644
--- a/slick.groupitemmetadataprovider.js
+++ b/slickgrid/slick.groupitemmetadataprovider.js
@@ -82,7 +82,7 @@
         var range = _grid.getRenderedRange();
         dataView.setRefreshHints({
           ignoreDiffsBefore: range.top,
-          ignoreDiffsAfter: range.bottom
+          ignoreDiffsAfter: range.bottom + 1
         });

         if (item.collapsed) {
@@ -106,7 +106,7 @@
             var range = _grid.getRenderedRange();
             dataView.setRefreshHints({
               ignoreDiffsBefore: range.top,
-              ignoreDiffsAfter: range.bottom
+              ignoreDiffsAfter: range.bottom + 1
             });
6pac commented 9 years ago

This has been integrated into my 'alternative master'. Any testing is appreciated. See https://github.com/mleibman/SlickGrid/issues/1055