search

mlemgroup / mlem

Mlem for Lemmy
https://lemmy.ml/c/mlemapp
GNU General Public License v3.0
162 stars 34 forks source link

[1.3] Fix marking as read #1076

Closed Sjmarf closed 4 weeks ago

Sjmarf commented 1 month ago

In 0.19.4, Lemmy removed support for the postId parameter of MarkPostReadRequest. From 0.19.4 onwards, only the postIds parameter can be used. postIds was introduced in 0.19.0, but both postId and postIds were supported until 0.19.4.

Without this fix, an error notification is shown when opening a post or opening the image viewer on a 0.19.4 instance. This PR uses the postIds parameter instead of postId on instances running 0.19.0 or higher, which fixes the issue.

We should release a 1.3.1 patch with this fix. At the moment, 0.19.4 is in the release candidate stage; lemmy.ml is the only major instance running 0.19.4.

Sjmarf commented 1 month ago

Feel free to merge - I can't because of the failed checks :D

We should also increment the version number if we're doing a release