search

mlemgroup / mlem

Mlem for Lemmy
https://lemmy.ml/c/mlemapp
GNU General Public License v3.0
178 stars 31 forks source link

Tap images to expand them #31

Open buresdv opened 1 year ago

buresdv commented 1 year ago

Introduction

As it is now, there is no way to tap on a picture and have it enter full screen.

Requirements

Add the possibility to tap on a picture to make it fullscreen. It should behave like in Photos, where tapping a picture expands it and then you can move it around and flick it away.

Should look like this: https://streamable.com/8xz0hv. Lemmy doesn't support albums, so there's no need to support more than one picture in a post.

What I Need

Rework the relevant files containing image views ( Post Item ) to support this feature. Also implement mlemgroup/mormaer-mlem#61 to comply with Apple's guidelines around NSFW material.

BrooklynMan commented 1 year ago

also, when expanded, a long-press should offer options to save the image to photos, share, etc. the standard options.

porkins commented 1 year ago

Similarly. If you tap a picture in a comment, such as the lemmy.world stickied starting guide, the behavior is a bit unexpected as it will just roll up the post. I wanted to tap the very large infographic to get into it, so I could zoom to see the small text.

rubythulhu commented 1 year ago

The only thing that makes mlem a sub-par lemmy app to me is that I can't save images, and have to do an awkward click "..." button -> share -> copy url -> paste into safari -> hope that doesn't fail -> save image via safari.

I just want to save memes :(

tht7 commented 1 year ago

Working on it man!

https://github.com/mlemgroup/mlem/pull/171

EricBAndrews commented 7 months ago

Moving this to "future"--we want to have a nice full-screen image viewer rather than the sheet, but that's a hefty chunk of development and should wait until post-2.0