Rotating Phone in All Loses Navigation Bar Translucency

d42ohpaz commented 1 year ago

Describe the bug After rotating the phone to landscape, and rotating it back to portrait, the translucency of the navigation bar is gone.

Expected Behavior The navigation bar to retain its thin material translucency.

Actual Behavior The translucency is completely gone.

To Reproduce Rotate the phone to landscape and rotate it back to portrait.

Mlem Information: Version 1.0.0 (213)

Additional Context N/A

https://github.com/mlemgroup/mlem/assets/2528463/38f355eb-f6a8-4330-9671-27772565c837

boscojwho commented 1 year ago

Couldn't reproduce on latest TestFlight build, possibly fixed by the new custom tab bar?

d42ohpaz commented 1 year ago

I’m using 1.0.1 (432) and the issue still exists. Are you on a dev version?

On Tue, Aug 8, 2023 at 9:53 PM Bosco Ho @.***> wrote:

Couldn't reproduce on latest TestFlight build, possibly fixed by the new custom tab bar?

— Reply to this email directly, view it on GitHub https://github.com/mlemgroup/mlem/issues/365#issuecomment-1670540240, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATJJT5ATPTDUUS23VOTF4LXULUTDANCNFSM6AAAAAA2WKVA7M . You are receiving this because you authored the thread.Message ID: @.***>

-- Do not go gentle into that good night, Rage, rage against the dying of the light.

Dylan Thomas

boscojwho commented 1 year ago

I’m using 1.0.1 (432) and the issue still exists. Are you on a dev version? On Tue, Aug 8, 2023 at 9:53 PM Bosco Ho @.> wrote: Couldn't reproduce on latest TestFlight build, possibly fixed by the new custom tab bar? — Reply to this email directly, view it on GitHub <#365 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATJJT5ATPTDUUS23VOTF4LXULUTDANCNFSM6AAAAAA2WKVA7M . You are receiving this because you authored the thread.Message ID: @.> -- Do not go gentle into that good night, Rage, rage against the dying of the light. - Dylan Thomas

Tested it on 1.0.1 (432) in light and dark modes, and still couldn't get a repro, odd.

Does it happen if you quit the app, do a fresh launch and immediate rotate the app?
What version of iOS are you on?
What iPhone are you using?

d42ohpaz commented 1 year ago

Tested it on 1.0.1 (432) in light and dark modes, and still couldn't get a repro, odd.

Does it happen if you quit the app, do a fresh launch and immediate rotate the app?

Yes.

What version of iOS are you on?

iOS 16.6

What iPhone are you using?

12 Pro Max

So for further clarity:

I scroll down a few posts and rotate the phone to landscape. The tab bar looks normal.
Then I rotate the phone back to portrait, the feed is scrolled back to the top, and the tab bar looks normal.
Then when I begins scrolling again, the tab bar stays stickied to the top so there is no background under the tab bar items.
If I scroll back to the top it looks like the tab bar is still there.

HTH.

PS. still occurs in latest RC1 version 1.0.1 (475).

boscojwho commented 1 year ago

PS. still occurs in latest RC1 version 1.0.1 (475).

Thank you, very useful info =)

Is this happening every time you rotate?

I ask because I went through that video frame by frame, and on rotating back to portrait, the "All" feed began to reload, which is not expected behaviour (especially if it's happening every time you rotate to portrait).

boscojwho commented 1 year ago

Finally reproduced this bug:

Xcode Version 15.0 beta 5 (15A5209g)
Simulator running iPhone 14 Pro Max (iOS 16.4)
Running /dev branch on commit d22c48e2d10e72285292a8272773abf5c267b3ec

Notes:

On rotate back to portrait, SwiftUI renders FeedView, and calls into .task(priority: .userInitiated) { await initFeed() } [line 69], this is not expected behaviour.
Post tracker is empty when this happens, which is not expected behaviour.
FeedView then first renders the else branch of the conditional content in noPostsView().
It then renders the if branch (LoadingView).
Finally, it renders the LazyVStack with the post tracker's items.

boscojwho commented 1 year ago

On rotate back to portrait:

FeedView: @self, @identity, _shouldBlurNsfw, _shouldShowPostCreator, _postSize, _showReadPosts, _appState, _filtersTracker, _favoriteCommunitiesTracker, _editorTracker, _feedType, _postTracker, _communityDetails, _postSortType, _isLoading, _shouldLoad changed.
Post tracker is empty
FeedView: _isLoading changed.

Identity change shouldn't be happening.

boscojwho commented 1 year ago

Not able to reproduce bug running iPhone 13 mini (simulator or device) and iPhone 12 Pro:

On those devices, SwiftUI isn't invalidating FeedView.

Note to self:

Was able to reproduce this issue on commit 32f551cf37c878fffb35e1d2ad3bdc8009c562c8, last commit on /dev branch that used the system TabBar:

So the ZStack inside FancyTabBar isn't(?) the issue here.

We want views to re-render on rotation events, but its identity shouldn't change.

What's weird is some of our other views aren't actually re-rendering on rotate, when they actually should re-render to fit inside the updated safe area....=/

😴

boscojwho commented 1 year ago

Update:

On rotate, FeedView body is called twice with @identity change.
Removing NavigationStack(path: $navigationPath) in FeedRoot around FeedView reduces this to just one @identity change.
Removing .handleLemmyViews() view modifier on FeedView fixes the other @identity change.

Unfortunately, nav bar translucency bug isn't caused by feed reloading on rotate.

boscojwho commented 1 year ago

Isolating this issue to the NavigationSplitView, removing it "fixes" issue:

Next step:

See if this is a SwiftUI bug with test project.

boscojwho commented 1 year ago

Scratch that, this line might be the issue [FeedView: line 63]:

getting very close to fixing this... T_T

Sjmarf commented 1 year ago

Fixed in #513

mlemgroup / mlem

Rotating Phone in All Loses Navigation Bar Translucency #365