mlemgroup / mlem

Mlem for Lemmy
https://lemmy.ml/c/mlemapp
GNU General Public License v3.0
169 stars 33 forks source link

Haptic Refactoring #412

Open EricBAndrews opened 1 year ago

EricBAndrews commented 1 year ago

Haptics should be moved to the edit middleware layer, rather than being scattered about as they currently are.

mormaer commented 1 year ago

@EricBAndrews - I think the haptics should be kept out of the repository layer as there may be places where we'd want to make a call to refresh something in the background, or chain a few calls together from one method on the repository which would then always result in haptics being fired.

I think we should keep the firing of haptics at the call site to give that flexibility?

EricBAndrews commented 1 year ago

That's a good point. This feels like a perfect application for the missing final chunk of middleware that handles middleware models (something like a fleshed-out tracker object)