Updated App Readme - Githubissues

mlevit / aws-auto-cleanup

Programmatically delete AWS resources based on an allowlist and time to live (TTL) settings

MIT License

496 stars 55 forks source link

Updated App Readme #134

Closed atqhg23 closed 1 year ago

atqhg23 commented 1 year ago

Description

Updated the app readme.

Added KMS to the resource ID and services tables
Updated resource names between resource ID and services tables to match
Updated list of actions in the exec log table
Created new table for exec log actions

Checklist

Generic

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Development

[NA] Have you added comments to all relevant changes within the code?
[NA] Have you lint your code locally prior to submission?
[NA] Have you formatted (Python Black and Prettier) your code locally prior to submission?

Testing

[NA] Have you created new tests for your submission?
[NA] Does your submission pass all tests?
[NA] Does your submission improve or at the very least kept code coverage at the same percentage?

Documentation

[X] Have you added or changed any and all applicable documentation?

mlevit commented 1 year ago

Thanks for that. I didn't see that this PR was against my km-cleanup branch :) woops.

Hopefully I didn't stuff anything up. Thanks for the PR.