search

mlevit / aws-auto-cleanup

Programmatically delete AWS resources based on an allowlist and time to live (TTL) settings
MIT License
496 stars 55 forks source link

Issue-#37: correcting the reference to LambdaHelper class #38

Closed samit2040 closed 4 years ago

samit2040 commented 4 years ago

Correcting the reference to LambdaHelper class in lambda_handler.py

Description

The AutoCleanup lambda wasn't able to read DynamoDB table auto-cleanup-whitelist-${stage}. The get_whiteList() method of lambda_handler.py used LambdaHelper class which exist in lambda_helper.py , the reference is incorrect. https://github.com/servian/aws-auto-cleanup/blob/master/auto_cleanup/lambda_handler.py#L193

def get_whitelist(self):
                parsed_resource_id = lambda_handler.LambdaHelper.parse_resource_id( .... 
def get_whitelist(self):
                parsed_resource_id = lambda_helper.LambdaHelper.parse_resource_id( ...
mlevit commented 4 years ago

@samit2040 thanks very much for the fix. I'm having some trouble with Travis. I've reached out to them for support. Once I fix the build we'll get this merged in.

mlevit commented 4 years ago

@samit2040 apologies for taking so long to fix this. Just found out that Travis doesn't work with forked merge requests due to secret environment variables. I've created my own request to validate this change #41