mlexchange / mlex_dlsia_segmentation_prototype

Other
3 stars 3 forks source link

Tibbers-Dev #4

Closed TibbersHao closed 8 months ago

TibbersHao commented 9 months ago

Revamp of the notebook

Description

This PR covers the recent changes of the dlsia integration with added features of Tiled I/O

Feature Upgrades

To Do's:

To Test:

Follow the instruction on README.

Note: UID needs to be changed if an container pre-exists in the Tiled Server, as currently there is no good way to delete containers.

dylanmcreynolds commented 9 months ago

resolves #2

dylanmcreynolds commented 9 months ago

We talked about writing the metrics out to the files system and perhaps accessing them in a browser

taxe10 commented 9 months ago

This is really cool! The test case detailed in the README file did not work at my end, I believe $(PARAMETERS) is not defined in the Makefile. Alternatively, the test with test_msdnet_maxdil went through correctly. Some suggestions moving forward:

TibbersHao commented 9 months ago

2 upgrades with latest commits:

  1. fixed the typo of $(PARAMETERS) -> $(TUNET_PARAMETERS) as a reflection of new commands in Makefile
  2. Added a Dockerfile and corresponding GitHub Workflow actions.
TibbersHao commented 9 months ago

Most of the comments have been addressed in the latest commit.

To Do:

Projected Finish Time:

TibbersHao commented 8 months ago

The recent commit addresses most of the comments above.

Key Feature Upgrades:

Note:

TibbersHao commented 8 months ago

Wrapping up this PR.

To address our previous discussion, @Wiebke , Changes that have been made:

  1. Fixed typo and changed back to logging.info().
  2. Deleted the apt-get line in Dockerfile, tested with docker build and image was built successfully.
TibbersHao commented 8 months ago

Side note:

Github actions of workflows have been added in one of the previous commits to automatically create the Dockerfile. It will need some attention to see if it works properly after merging.