mlflow / mlflow-export-import

Apache License 2.0
132 stars 78 forks source link

Export parent runs in export-models #134

Open hoiting opened 1 year ago

hoiting commented 1 year ago

Hi,

I have a few instances where some runs have parent runs. In that case, it seems like export-models need to export parent runs in order for the later import-models to properly import the models. If not, common.utils.nested_tags will fail, due to the src_parent_run_id not known.

Proposed solution: I trace this back to bulk.model_utils.get_experiments_run_of_models, where in the inner for loops, one has to include two more lines in the try block to include parent runs into the export.

                run = client.get_run(vr.run_id) #original code
                exps_and_runs.setdefault(run.info.experiment_id,[]).append(run.info.run_id)  #original code
                parent_run = client.get_parent_run(vr.run_id)  #new code
                if parent_run: exps_and_runs[run.info.experiment_id].append(parent_run.info.run_id)  #new code

It would be great for you to take this into consideration. Thanks!

amesar commented 1 year ago

Great, thanks for the investigation and suggestion. Will look at it shortly.