mlflow / mlflow-go

Repository for the Go-based MLflow Tracking Server
Apache License 2.0
5 stars 4 forks source link

Add SetTag endpoint #10

Closed jescalada closed 1 month ago

jescalada commented 1 month ago

PR for adding the SetTag endpoint. I also added the DeleteTag endpoint from #8.

There are various new tests, all of which are passing except one:

The reason why test_set_tag is failing, is that it uses monkeypatch to set an env, which doesn't flow to the Go side in our implementation. I have temporarily disabled that specific test by adding it to conftest.py until we can find a solution for similar tests.

I also added a test:PythonSpecific command for testing a single endpoint at a time.

jescalada commented 1 month ago

Looks like I messed up the line endings, will fix in a sec!

dsuhinin commented 1 month ago

It feels like you need to re generate mocks.

jescalada commented 1 month ago

I managed to get the test_set_tag_validation test to pass, however, I did this via a manual check in /pkg/tracking/service/tags.go. I also added the custom validator for the runId, however I am not sure how to integrate this with the existing code.

Is this meant to be used in our own Go tests? I noticed that for the LogBatch we're doing custom tests in /pkg/validation/validation_test.go.

nojaf commented 1 month ago

Oh and please rebase on latest main.