'inspect' command: display master apps of a given node host

mlfmonde / cluster_cli

A client utility to easly administrate cluster

MIT License

0 stars 2 forks source link

'inspect' command: display master apps of a given node host #11

Closed pyseed closed 5 years ago

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 33

16 of 23 (69.57%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.09%) to 95.862%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
cluster/cluster.py	1	8	12.5%
<!--	Total:	16	23	69.57%	-->

Totals
Change from base Build 32:	-1.09%
Covered Lines:	556
Relevant Lines:	580

Pull Request Test Coverage Report for Build 33

16 of 23 (69.57%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.09%) to 95.862%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
cluster/cluster.py	1	8	12.5%
<!--	Total:	16	23	69.57%	-->

Totals
Change from base Build 32:	-1.09%
Covered Lines:	556
Relevant Lines:	580

Pull Request Test Coverage Report for Build 33

16 of 23 (69.57%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.09%) to 95.862%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
cluster/cluster.py	1	8	12.5%
<!--	Total:	16	23	69.57%	-->

Totals
Change from base Build 32:	-1.09%
Covered Lines:	556
Relevant Lines:	580

Pull Request Test Coverage Report for Build 54

45 of 45 (100.0%) changed or added relevant lines in 3 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.09%) to 97.173%

Files with Coverage Reduction	New Missed Lines	%
cluster/tests/test_migrate.py	2	97.85%
cluster/cluster.py	4	97.74%
<!--	Total:	6	-->

Totals
Change from base Build 43:	0.09%
Covered Lines:	653
Relevant Lines:	672

💛 - Coveralls

petrus-v commented 5 years ago

Thanks for this works!

Do you mind to add a test case to improve coverall and avoid regression on this new features ?

I guess you can find inspiration how to do it from this check test test to assert consol output.

And you could probably reuse/refactor fill_data method.

Next evolution could be to add a --format option to let user choose wich fields to add per service, for instance it could be nice to display the deploy date or deploy id. But probably doing that in an other PR, what do you think about ?

Regards

pyseed commented 5 years ago

Thanks for input.

Yes i will fix coverage in same PR, fields improvement will go in another PR.

pyseed commented 5 years ago

@petrus-v Hi. coverage improved, PR candidate for a merge.

pyseed commented 5 years ago

@petrus-v readme/changelog updated, PR candidate for merge

petrus-v commented 5 years ago

LGTM, thanks for that feature