search

mlgig / mrseql

A sktime-independent Python wrapper for MrSEQL
MIT License
1 stars 0 forks source link

`pyproject.toml` should contain `sktime` and `numba` as dependencies #1

Open fkiraly opened 1 year ago

fkiraly commented 1 year ago

As far as I can tell from the sktime test suite runs here: https://github.com/sktime/sktime/pull/5178, the package does depend on both numba and sktime via the SFA estimator.

Should this not be added to pyproject.toml?

If not, users installing the package will not have sktime and numba installed when instaling mrseql and will encounter uninformative error messages.

FYI @lnthach

fkiraly commented 1 year ago

Update:

upon closer investigation, the dependency is only there if the feature set includes the "sfa" string. That makes numba and sktime conditional dependencies, only for certain parameter setting.

In this case, I think it makes sense to not make them dependencies of the package, and raise appropriate error messages if the condition is met - the precise condition being the string "sfa" being contained in symrep.