mlgig / mrseql

A sktime-independent Python wrapper for MrSEQL
MIT License
1 stars 0 forks source link

mrseql 0.0.3-0.0.5 fail sktime interface conformace tests #3

Open fkiraly opened 1 month ago

fkiraly commented 1 month ago

The new release 0.0.4 from Aug 2 fails the sktime interface conformance tests!

See example failures here:

https://github.com/sktime/sktime/actions/runs/10221468849/job/28284128036

I would suggest to have a CI element that runs check_estimator on the sktime interface, in this repository, happy to help out with this.

For now, we can solve the issue by restricting the MrSEQL version, here: https://github.com/sktime/sktime/pull/6879

Though this does not solve the underlying issue.

fkiraly commented 1 month ago

mrseql 0.0.5 also fails the interface tests

lnthach commented 1 month ago

@fkiraly Could this be because mrseql 0.0.4 was installed from the source distribution ? I just uploaded the built distribution for v0.0.4 so please let me know if it still fails.