search

mlgualtieri / CSS-Exfil-Protection

Official repository for the CSS Exfil Protection browser extensions.
MIT License
155 stars 11 forks source link

Potential indexOf bug #1

Closed mrjacobbloom closed 6 years ago

mrjacobbloom commented 6 years ago

I just finished reading your article on CSS Exfil and it was super intriguing! Amazing work! I was looking through the code and noticed something that looked a little iffy:

https://github.com/mlgualtieri/CSS-Exfil-Protection/blob/b5317c70b3862b3eef7ba553cf316724f447f3c0/chrome/content.js#L232

Should this be indexOf('background') !== -1? Right now the condition is true when "background" is at any index except 0 or doesn't exist

mlgualtieri commented 6 years ago

Thank you for the bug report! I need to tweak my github notification settings as I didn't realize you had added this. I really appreciate it. Yes, I believe you are correct. Will address with an update asap.

mlgualtieri commented 6 years ago

1.0.7 release should fix this, thanks again!