Shows badge when disabled?

mlgualtieri / CSS-Exfil-Protection

Official repository for the CSS Exfil Protection browser extensions.

MIT License

155 stars 11 forks source link

Shows badge when disabled? #11

Closed B00ze64 closed 5 years ago

B00ze64 commented 5 years ago

Good day.

Did you finally certify OSCP? New version of CSS Exfil still creates issue on Amazon, but something new I want to report : When I disable the protection, the icon shows a badge with "-" inside. It's kinda superfluous, the icon's all black, I can tell it's disabled; if it shows the badge on top, I'm kinda wondering what's going on ;-)

Regards,

mlgualtieri commented 5 years ago

Yes, I did finish OSCP this past August! It was a fun challenge!

I'll see what I can do about the - on the disabled badge. I originally added this because of a display issue when it was re-enabled, but I'll revisit.

I have not found a good solution to the Amazon issue. I looked into this again when I put out the .10 and .11 releases a month ago. I can confirm that when this happens, if you resize your browser screen the areas snap back to display properly. I attempted to fix by simulating a window resize in JavaScript, but this doesn't do the trick.

B00ze64 commented 5 years ago

Congrats!

When it's disabled, there should be no badge at all, no? It's not really the dash, it's the fact that it shows a badge. All my extensions, when there's a badge it means the extension is active, and if it says zero, that it did not find anything (but it's active)...

Amazon: Ah, I didn't think of resizing the window, I didn't know it was all tucked away on the side, I thought that that part of the page just had not loaded correctly at all. I tend not to resize; on Firefox with the old TabGroups all the groups get mangled if you change the window size even by 1 pixel. Guess a WhiteList is the only way around it...

Regards,

mlgualtieri commented 5 years ago

I just pushed code edits to github that improves the disabled / reenabled icon states. Will be pushing out release 1.0.12 shortly for Chrome and Firefox.