mlgualtieri / CSS-Exfil-Protection

Official repository for the CSS Exfil Protection browser extensions.
MIT License
155 stars 11 forks source link

Add localisation for future translation (En + Fr) #27

Closed ghost closed 4 years ago

ghost commented 4 years ago

I have added the language management and translated the extension in French (the extension will automatically change language depending on the active localization in the browser (the default one is English in case the said language is not available in the translations already done),

I also retrieved the version number from the manifest so you won't have to manually change the version number in popup.html in the next releases. The text of popup.html is added via javascript in popup.js @mlgualtieri

mlgualtieri commented 4 years ago

Awesome, thanks! I'll need to take your word that the translations are accurate :-)

I'll merge this into the next release, which will hopefully be later this week. Lot's of bugfixes and improvements in the forthcoming 1.0.18 release.

ghost commented 4 years ago

for french yes it's accurate, i can do other languages, but if i do it will be with deepl translator (so i prefer let a native speaker create these languages to be sure it accurate).

edit: i'm a native french (that why i have added french (but i use it in English so the translation is for the other french) 👍

mlgualtieri commented 4 years ago

I agree on that point. Let's just keep it with English/French for now, and if there's demand for other languages maybe users can supply translation.

ghost commented 4 years ago

at least after the merging, the translation will be very easy, and if you add a new thing on the popup all you have to do, you open an issue, and mention me (and other translator later) and we will translate the new thing shortly after ;)

ghost commented 4 years ago

@mlgualtieri i have updated the merge for take account of your change (but it must be tested), but normally it must work

ghost commented 4 years ago

@mlgualtieri i have added " default-src 'self' " in csp like recommended in https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/default-src for directives that are absent in CSP. When you will update i will check the pull request again (just in case)

mlgualtieri commented 4 years ago

The CSP patch sounds fine. I'll need to test to make sure it doesn't have an ill effects, but doesn't seem like it would. I need to hold off merging in the new language edits until all the new settings are in place, since it will add new text to popup.html. I'm expecting to release what's currently in github today, ahead of Chrome 85, and will have some other updates soon in the next release that will add more settings.

ghost commented 4 years ago

Focus on your thing, i will correct my pull request when you are done ^^ So later you can do a .1 or .2 with translation.

ghost commented 4 years ago

Conflict resolved (will test if all work well after a little sleep xD)

edit: some translate to do will do that too after little sleep ^^

ghost commented 4 years ago

@mlgualtieri patch + translation done to 1.1.0 update , tested on firefox and vivaldi (chromium), but since my browser is in french i don't have tested english version (but if it work in french it must work in english)

ghost commented 4 years ago

patch to the CSP for add connect-src https://* to it now it rework fine

ghost commented 4 years ago

to correct csp error when encounter a base 64 picture i have added data: to csp under connect-src to manifest json

ghost commented 4 years ago

transfer data: to img-src in the csp (error of data: created on the option page from extension)

ghost commented 4 years ago

@mlgualtieri just to report since the last push on manifest i don't have trigger any error in the console (Vivaldi), if someone else want to try, before an eventual merge it will be nice (since i don't really use problematic website (the website who usually trigger an issue in this repository), i think more testing must be do to be sure my push don't break anything (especially the CSP in manifest.json)

ghost commented 4 years ago

@mlgualtieri any news on this ?

mlgualtieri commented 4 years ago

I haven't had a chance to work on the plugin since the last release.  Although I've received no errors with the current CSP in manifest.json, so it might be a better idea to leave that edit unchanged when I roll in this patch.

ghost commented 4 years ago

@mlgualtieri Sorry for the delay, the csp is reset at the actual version in your repository like you have asked, you can test but normally it work.