Change on mlhub.pkg - Githubissues

mlhubber / mlhub

Machine Learning Model Repository Hub Command Line Tool.

MIT License

20 stars 12 forks source link

Change on mlhub.pkg #253

Closed davecatmeow closed 2 years ago

davecatmeow commented 2 years ago

Change the behaviour of pkg.mlask() and pkg.mlpreview(), which are both crucial for current developing package.

For mlask, mainly changing the waiting for Enter implementation from input() to an cross-platform getChar(), to avoid the non-response bug after mlpreview
For mlpreview, now the defalt viewer would call system defalt application to open file.

davecatmeow commented 2 years ago

Thanks for the test, the bug is due to not properly handle the "\n" character. Now it shall be fixed, and I also tested the kmeans demo.py on the new mlhub.pkg

gjwgit commented 2 years ago

Manually resolved conflicts and merged.