search

mlibrary / hydra-prototype

4 stars 6 forks source link

Move Deep Blue models into DeepBlue namespace #30

Open respinos opened 8 years ago

respinos commented 8 years ago 
bundle exec rails g curation_concerns:work Item
# bundle exec rails g curation_concerns:work Collection

(Just the Item.)

respinos commented 8 years ago

Guess before we load too much data into the repository!

njaffer commented 8 years ago

Does that mean that Deep Blue Collection would be a Generic Work and not Collection?

respinos commented 8 years ago

Good catch: it would generate it as a GenericWork, but we'd just swap out the includes.

BUT the generator is broken with respect to namespaces, so this isn't going to work. Investigating.

respinos commented 8 years ago

Curation Concerns clearly does not expect you to namespace your models --- note that the Rackham controller is actually CurationConcerns::RackhamsController. I don't know if we want CurationConcerns::DeepBlue::ItemController, but I need to do further research.

I'm also baffled why Curation Concerns doesn't configure rspec tests for the collection objects.

respinos commented 8 years ago

This explains my motivation for namespaces:

http://blog.makandra.com/2014/12/organizing-large-rails-projects-with-namespaces/

It's easy to see we'd end up with gems for "umich-deep-blue" and "umich-dlps-image" and "umich-dlps-findaid", any combination of being used in a head.

But I do suspect the namespacing is beyond the scope of this prototype.

njaffer commented 8 years ago

Yep agreed. This is not the scope of this sprint

blancoj commented 8 years ago

Great link roger. Easy to understand namespacing now. Thank you!

On Tue, Oct 13, 2015 at 4:29 PM, respinos notifications@github.com wrote:

This explains my motivation for namespaces:

http://blog.makandra.com/2014/12/organizing-large-rails-projects-with-namespaces/

It's easy to see we'd end up with gems for "umich-deep-blue" and "umich-dlps-image" and "umich-dlps-findaid", any combination of being used in a head.

But I do suspect the namespacing is beyond the scope of this prototype.

— Reply to this email directly or view it on GitHub https://github.com/mlibrary/hydra-prototype/issues/30#issuecomment-147842781 .