mlibrary / mgetit

6 stars 0 forks source link

Put cover image into display #11

Closed varnum closed 8 years ago

varnum commented 8 years ago

It's still on the dev version, but not on earleyj, for the same citation.

jonearley commented 8 years ago

I've noticed some inconsistencies when the cover displays too. @bertrama could you help me investigate?

bertrama commented 8 years ago

Are we going to do cover images through Umlaut's existing services or how Bill does them in Mirlyn?

varnum commented 8 years ago

Is there an inherently better option?

On Wednesday, August 17, 2016, Albert Bertram notifications@github.com wrote:

Are we going to do cover images through Umlaut's existing services or how Bill does them in Mirlyn?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mlibrary/mgetit/issues/11#issuecomment-240466355, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ7bLyjqytM1SRBaaOjdkR96vuNLIdVOks5qgzWDgaJpZM4Jha2b .

Ken Varnum Senior Program Manager for Discovery, Delivery, and Library Analytics Library Information Technology | University of Michigan Library varnum@umich.edu | @varnum | 734-615-3287 http://www.lib.umich.edu/users/varnum

jonearley commented 8 years ago

Here is an example with a cover image: https://earleyj.www.lib.umich.edu/testapp/mgetit/go/294

cover_image

@varnum, @bertrama

Is there a way to test when an item should have a cover image, but doesn't? It seems like cover images are working, but they are rare for most items.

varnum commented 8 years ago

Thanks

Ken Varnum Senior Program Manager for Discovery, Delivery, and Library Analytics Library Information Technology | University of Michigan Library varnum@umich.edu | @varnum | 734-615-3287 http://www.lib.umich.edu/users/varnum

On Mon, Aug 22, 2016 at 2:02 PM, Jon Earley notifications@github.com wrote:

Here is an example with a cover image: https://earleyj.www.lib.umich. edu/testapp/mgetit/go/294

[image: cover_image] https://cloud.githubusercontent.com/assets/1678665/17865382/57c6f0b2-6870-11e6-8fbe-fb9ca21c62e9.png

@varnum https://github.com/varnum, @bertrama https://github.com/bertrama

Is there a way to test when an item should have a cover image, but doesn't? It seems like cover images are working, but they are rare for most items.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mlibrary/mgetit/issues/11#issuecomment-241497489, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ7bL81C5lfh6bl0lBe3w0UC8zFT7Jzaks5qieRGgaJpZM4Jha2b .

jonearley commented 8 years ago

Done. Placeholder image not necessary.