mlibrary / online-exhibits

Online Exhibit Website using Omeka (CMS)
GNU General Public License v3.0
3 stars 3 forks source link

Repetitive alt attribute / title attribute / title text #327

Closed bertrama closed 6 years ago

bertrama commented 6 years ago

For example, in /exhibits/browse: The <img> tag's alt, and title attributes are the same as the text in the <h3> tag. @bnhowell says that in this case the img tag is decorative.

Additionally, it may be preferred to reduce the duplicated links, related to issue #299.

<div class="col-xs-12 browse-wrap">
  <div class="col-xs-12 col-sm-3">
    <div class="img-wrap">
      <a href="/online-exhibits-o261/exhibits/show/seven-fantasy-classics" class="image">
        <img alt="Seven Fantasy Classics for Children"
                 src="https://www.lib.umich.edu/online-exhibits-o261/files/square_thumbnails/9e9104ac9811b03f915892f9cd7d8435.jpg"
                 title="Seven Fantasy Classics for Children">
      </a>
    </div>
  </div>
  <div class="col-xs-12 col-sm-9">
    <h3 class="item-heading">
      <a href="/online-exhibits-o261/exhibits/show/seven-fantasy-classics">
        Seven Fantasy Classics for Children
      </a>
    </h3>
    <p class="item-description">
      What accounts for the persistent power and enchantment of fantastical figures like Cinderella, Alice, Aladdin, and Peter Pan? How have tales about such characters been reworked and reimagined over the years to make them fresh for new audiences in new cultural contexts? Our English 313 class invites…
    </p>
    <div class="tags">
      <ul class="tag-list">
        <li>Tags:</li>
        <a href="/online-exhibits-o261/exhibits/browse?tags=Children%27s+Literature" rel="tag">Children's Literature</a>
        <a href="/online-exhibits-o261/exhibits/browse?tags=U-M+Library+Special+Collections" rel="tag">U-M Library Special Collections</a>
      </ul>
    </div>
  </div>
</div>
bnhowell commented 6 years ago

@nancymou While testing the fixed alternative text for #329, I found this as a warning in WAVE around the issue in this ticket about duplicative or redundant links in the browse page and search results pages.

My recommendation is to either: 1) remove the link from the image or 2) To investigate a solution where the image has null alt text and is part of a white raised 'result card' where the Title of the Exhibit links to the exhibit and where individual tags link to a browse page with the tag applied.

Browse page with redundant links warning: screen shot 2018-10-17 at 10 19 02 am

Search results page with redundant links warning: screen shot 2018-10-17 at 10 12 34 am

nancymou commented 6 years ago

@bnhowell for solution 1, do you need the alt = '' as well? currently, it is assigned to the exhibit title.

nancymou commented 6 years ago

@bnhowell check browse page in my development.

or https://beta3.www.lib.umich.edu/online-exhibits-2.5.1/exhibits

nancymou commented 6 years ago

https://beta3.www.lib.umich.edu/online-exhibits-2.5.1/ has the up to date version with fixes