mliebelt / pgn-viewer

Simple PGN viewer with the necessary features to display chess games
GNU General Public License v3.0
161 stars 44 forks source link

Player name and coordinates overlap #452

Open braoult opened 1 year ago

braoult commented 1 year ago

White player name and coordinates overlap.

To reproduce (Configuration Builder): Load Evergreen (No board), tick Show Coordinates and untick Coords Inner, to get coordinates outside the board. We get:

image

Now, tick Headers, to add players name. We get :

image

Interesting part is that the buttons bar is moved down, as if the space used by player name was taken into account, and only name placement is actually wrong.

mliebelt commented 1 year ago

True. There is a correction done, but seems to be on the wrong element. I will check that, by producing an example that contains both elements (headers and coordinates out) to reproduce it. Should not be too complicated .... ( I hope :-) ).

mliebelt commented 1 year ago

I think I found the reason, does not want to do a release because of that.

braoult commented 1 year ago

Good ! and no problem for the release. For my information, is it a CSS-only problem, that I could try locally ?

mliebelt commented 1 year ago

No. There is some logic needed to set the CSS dependent on the configuration. So not so easy to fix in CSS only ...