mlim-usfca / PersonalKnowledge

https://personal-knowledge.vercel.app
0 stars 0 forks source link

Add frontend v1 #15

Closed TanyaaCJain closed 7 months ago

TanyaaCJain commented 7 months ago

Kindly read README

Post this PR, the main things pending are:

inhwaS commented 7 months ago

Based on our final version of PRD, two categories should be To learn and To visit. Please update :)

inhwaS commented 7 months ago

I think you wanted to put login page but the user icon only shows this page. Where can I see login form? Screenshot 2024-03-31 at 10 53 27 AM

TanyaaCJain commented 7 months ago

@inhwaS

Based on our final version of PRD, two categories should be To learn and To visit. Please update :)

Sure, I'll do that

I think you wanted to put login page but the user icon only shows this page. Where can I see login form?

If you see the README for web, I have mentioned how to toggle authentication until we integrate all the APIs. Everyone can use that to checkout the non-authenticated page

TanyaaCJain commented 7 months ago

Hi Tanya, I encountered this problem:

inhwa.son@Inhwas-MacBook-Air PersonalKnowledge % docker-compose -f docker-compose.dev.yml up
service "web" depends on undefined service graphql-engine: invalid compose project

Seems like you depends_on graphql-engine but I don't think it is necessary for now.

The code has already been updated to fix this issue. Seems like all files did not get changed on your local :/

inhwaS commented 7 months ago

@inhwaS

Based on our final version of PRD, two categories should be To learn and To visit. Please update :)

Sure, I'll do that

I think you wanted to put login page but the user icon only shows this page. Where can I see login form?

If you see the README for web, I have mentioned how to toggle authentication until we integrate all the APIs. Everyone can use that to checkout the non-authenticated page

Got it, I could see this page, thanks !

Screenshot 2024-04-01 at 6 27 25 PM