57 general unit test - Githubissues

mlim-usfca / PersonalKnowledge

https://personal-knowledge.vercel.app

0 stars 0 forks source link

57 general unit test #60

Closed GuoFan1996 closed 4 months ago

GuoFan1996 commented 4 months ago

PR Summary

This PR adds the pgtap extension for improved database testing and removes unused columns

Key Changes

Added pgtap extension for enhanced database testing.
Schema cleanup by removing unused columns from links and document_sections.

Testing Instructions

Run supabase db reset to apply schema changes.
Run supabase db test to validate the updates with new tests.

Please review the changes for accuracy and efficiency. @hazalsenturk Since I removed tag column, please check chat functionality carefully before approval.

hazalsenturk commented 4 months ago

Played with app a while. The table relations works just fine with chat. Good job @GuoFan1996 thank you!

Before we merge, regarding the embeddings can you please check this one scenario for the link I shared. Once I save this link and chat with the RAG category the embeddings created does not cover the whole post. For example the information about the challenges are not included in the db so it constantly say that sorry I could not find the data. Link to save: https://www.databricks.com/glossary/retrieval-augmented-generation-rag Question to ask: What are the challanges?

GuoFan1996 commented 4 months ago

Played with app a while. The table relations works just fine with chat. Good job @GuoFan1996 thank you!

Before we merge, regarding the embeddings can you please check this one scenario for the link I shared. Once I save this link and chat with the RAG category the embeddings created does not cover the whole post. For example the information about the challenges are not included in the db so it constantly say that sorry I could not find the data. Link to save: https://www.databricks.com/glossary/retrieval-augmented-generation-rag Question to ask: What are the challanges?

Is this part of information extracted correctly? Or only embeddings are not generated completely?

inhwaS commented 4 months ago

I guess this PR solves #61 issue?!