search

mlim-usfca / PersonalKnowledge

https://personal-knowledge.vercel.app
0 stars 0 forks source link

Replacing main with dev since Firebase/Hasura are discarded #9

Closed inhwaS closed 7 months ago

cemtu commented 8 months ago

Do we need reviewers to merge changes from dev to main? Since we approved them while merging to dev, why we need to approve same changes second time?

--

If we're working in terms of different releases, and if each release will contain some specific features, and if the dev can include any changes apart from the targeted release features, then I can understand why. But just wanted to ask.

inhwaS commented 8 months ago

Do we need reviewers to merge changes from dev to main? Since we approved them while merging to dev, why we need to approve same changes second time?

--

If we're working in terms of different releases, and if each release will contain some specific features, and if the dev can include any changes apart from the targeted release features, then I can understand why. But just wanted to ask.

Whenever we create dev -> main, we still need to make PR since it will summarize the dev updates into main. It's only simple one PR to main but when there are multiple releases will be applied into main, we should write a brief summarization and ask 2 people to approve it. Hope this makes sense!