search

mlir-rs / melior

The rustic MLIR bindings in Rust
https://mlir-rs.github.io/melior/melior/
Apache License 2.0
332 stars 39 forks source link

Re-export `mlir_sys` #588

Open cospectrum opened 2 months ago

cospectrum commented 2 months ago

To close https://github.com/raviqqe/melior/issues/583

raviqqe commented 2 months ago

@edg-l Do you think this is a good change?

I feel like this is the responsibility of the package manager (i.e. Cargo.) But at the same time, I've never hit problems @cospectrum described in the original issue.

edg-l commented 2 months ago

I dont have an opinion on this, but with cargo you can have multiple versions with package renaming

raviqqe commented 2 months ago

@edg-l Yeah, that's what I've suggested in #583 too.

@cospectrum How critical is this change to your workflow?

cospectrum commented 2 months ago

Well, that's quite important for me. Every time I run cargo update, for example, the workspace has a chance to not compile anymore, and cargo will not prevent it. To fix the compile error, I should find melior version in Cargo.lock, then find out exact version of its mlir_sys somewhere (crates.io or lock file), and then I should downgrade my own mlir_sys in Cargo.toml manually.

cospectrum commented 2 months ago

I think PR will not cause problems at all. But it will solve one problem for me!