search

mlisook / plastic-image

A Polymer 3.0 element which adds extra plasticity to <iron-image> with support for srcset and lazy loading
MIT License
30 stars 6 forks source link

importPath is undefined #42

Closed elarb closed 6 years ago

elarb commented 6 years ago

Currently the importPath is used for the source of the polyfill script (needed for e.g. IE 11), but it seems to be undefined, causing the client to request undefinedintersection-observer.js. It might have to do with a missing <dom-module> wrapper in the element definition, as discussed in Polymer/docs/issues/2466.

mlisook commented 6 years ago

Thank you for reporting this.

May I ask what version number of this element, and what Polymer version you are using.

elarb commented 6 years ago

I am using version 3.0.0 of this element and 3.0.2 of Polymer

mlisook commented 6 years ago

Thank you, I'll investigate immediately.

mlisook commented 6 years ago

I've merged PR #43 to address this. I had not included a static getter that is required if using importPath as described in the Polymer 3.0 upgrade guide

I've also published the update to NPM - version 3.0.2

Thanks again for finding and reporting this issue.

elarb commented 6 years ago

Thanks, that indeed fixed the issue. Very nice to see it being addressed this quickly. Great work on <plastic-image> !