search

mlj / castget

A simple, command-line based RSS enclosure downloader, primarily intended for automatic, unattended downloading of podcasts.
http://castget.johndal.com
GNU General Public License v2.0
103 stars 23 forks source link

castget on FreeBSD 9.3 amd64 does not find g_strlen (src/progress.c:95) #7

Closed opsec closed 8 years ago

opsec commented 8 years ago

See

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206565

and the attachment, where I replaced g_strlen with strlen. Which compiles, but I do not understand the details of gnome to know if this really fixes the issue. Is the patch correct or what would be the correct patch ?

Without it, it fails to build, see

http://people.freebsd.org/~pi/logs/www__castget-93a-1453624637.txt

mlj commented 8 years ago

Thanks for you report, which revealed a more serious bug.

First, g_strlen is a typo and should be replaced by strlen.

The more serious problem is that the variable columns is never initialized. I guess the reason why this compiles on my platform (gcc 5.3/x86_64 Linux) is that the compiler eliminates the entire block.

mlj commented 8 years ago

I have uploaded a new version (1.2.2) with this fix. @opsec, can you verify that it builds on FreeBSD?

opsec commented 8 years ago

testing@work

opsec commented 8 years ago

cur 93a 10a 10i builds done, all fine.