mljar / mljar-api-python

A simple python wrapper over MLJAR API.
https://docs.mljar.com/
Apache License 2.0
42 stars 10 forks source link

mljar.fit returning prediction from result not belong to my current experiment #2

Closed shadiakiki1986 closed 7 years ago

shadiakiki1986 commented 7 years ago

There are multiple experiments in my project. When I ran mljar.fit(...) for my 2nd experiment, I got results that looked like results from my 1st experiment. Digging deeper, I found that the function ResultClient(project id).get_results(experiment id) (link) was not filtering the results for the experiment ID being passed. For example, the code below


clf_mlj = Mljar(
  project='some project name',
  experiment='some experiment name',
  ...
)

from mljar.client.result import ResultClient
client = ResultClient(clf_mlj.project.hid)
results = client.get_results(clf_mlj.experiment.hid)
len(results) # returns 75
results = client.get_results(None)
len(results) # returns 75 as well
pplonski commented 7 years ago

Thank you! I'll work on that.

pplonski commented 7 years ago

Fixed!