search

mljar / mljar-supervised

Python package for AutoML on Tabular Data with Feature Engineering, Hyper-Parameters Tuning, Explanations and Automatic Documentation
https://mljar.com
MIT License
3.03k stars 404 forks source link

Make BaseAlgorithm inherit from ABC #163

Open diogosilva30 opened 4 years ago

diogosilva30 commented 4 years ago

Since BaseAlgorithm is an abstract class, it should inherit from ABC, and the methods that must be implemented in child classes should be decorated with @abstractmethod. This could potentially prevent coding errors to fly under the radar, as it enforces child classes to implement methods. Thoughts on this @pplonski ?

pplonski commented 4 years ago

@spamz23 you are right.

There are two more places that will need better code and refactoring: preprocessing and ensembling. Have you looked at them?

What do you think about this AutoML package, do you think it can be more popular than existing ML packages, for example, scikit-learn?

diogosilva30 commented 4 years ago

No I haven't. Do you to assign me this task?