search

mljar / mljar-supervised

Python package for AutoML on Tabular Data with Feature Engineering, Hyper-Parameters Tuning, Explanations and Automatic Documentation
https://mljar.com
MIT License
3.05k stars 406 forks source link

strings in golden_features.json #227

Closed SuryaThiru closed 3 years ago

SuryaThiru commented 3 years ago

The golden features JSON file that is being saved by mljar contains strings for new_features and new_columns instead of dictionaries which makes it a little difficult to view/parse the file.

Current output: image

Expected output: image

We can avoid using the indented JSON string here while saving the model unless there is some other specific reason to do so.

pplonski commented 3 years ago

Hey @SuryaThiru! You are right, the indent is not needed here. Would you like to PR?

SuryaThiru commented 3 years ago

Yes, I can do that.

pplonski commented 3 years ago

@SuryaThiru thank you! Good fix!