search

mljar / mljar-supervised

Python package for AutoML on Tabular Data with Feature Engineering, Hyper-Parameters Tuning, Explanations and Automatic Documentation
https://mljar.com
MIT License
3.05k stars 406 forks source link

Bug: 'KNeighborsAlgorithm' object has no attribute 'classes_' #669

Closed strukevych closed 1 month ago

strukevych commented 12 months ago

Current behavior: 'KNeighborsAlgorithm' object has no attribute 'classes_' Problem during computing permutation importance. Skipping ...

Expected: KNeighbors to be trained

pplonski commented 11 months ago

Which version are you using?

strukevych commented 11 months ago

Python 3.11 mljar 1.1.1

pplonski commented 11 months ago

Thanks @strukevych, looks like it is some bug. PR are welcome!

Hk669 commented 11 months ago

hey @pplonski , i am keen on contributing and would like to gather more information to better understand the problem and work towards a resolution.

Hk669 commented 11 months ago

@pplonski , made a PR #679 . i think this will solve the issue for the _classes attribute in the KNieghborsAlgorithm

pplonski commented 11 months ago

Thank you @Hk669, I've added comments to PR.

pplonski commented 1 month ago

@Marchlak are we able to reproduce the issue, or it was fixed with 1.5 scikit-learn?

Marchlak commented 1 month ago

@pplonski I haven't encountered this problem