mljs / global-spectral-deconvolution

Global Spectra Deconvolution + Peak optimizer
http://mljs.github.io/global-spectral-deconvolution/
MIT License
9 stars 8 forks source link

fix: joinBroadPeak n types #91

Closed jobo322 closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #91 (7402c5b) into master (cd65dbc) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   95.97%   95.98%   +0.01%     
==========================================
  Files           8        8              
  Lines         273      274       +1     
  Branches      100      101       +1     
==========================================
+ Hits          262      263       +1     
  Misses         11       11              
Impacted Files Coverage Δ
src/post/optimizePeaks.ts 94.28% <ø> (ø)
src/gsd.ts 97.08% <100.00%> (-0.09%) :arrow_down:
src/index.ts 100.00% <100.00%> (ø)
src/post/joinBroadPeaks.ts 89.58% <100.00%> (+0.45%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cd65dbc...7402c5b. Read the comment docs.

lpatiny commented 2 years ago

I have updated the branch homogenizeTypes. Do you have the webpage with jsgraph showing the result of this algorithm ? I'm surprised you try to fit something that is not the original data and would like to understand why.

lpatiny commented 2 years ago

Difficult for me to know if this is correct or not. Nothing shocking in the code.

Did you succeed to have an image in the browser with a simple result (based on jsgraph) this should be added in this PR.

But we can merge and make a release if you want.