search

mljs / levenberg-marquardt

Curve fitting method in JavaScript
MIT License
70 stars 15 forks source link

Explain test data used in fitting test #25

Open jacobq opened 6 years ago

jacobq commented 6 years ago

The test suite contains a set of points to fit without indicating where those numbers came from. Plotting them in Excel suggests that the 3rd value (y = 21.119) may be a typo (instead of y = 2.119).

The value added by a test suite is only as good as the tests are meaningful. Does anyone know where these data came from? Were they measured from some physical process? Were they generated by a mathematical model of some kind? etc.

https://github.com/mljs/levenberg-marquardt/blob/afbbd9055d539bc120180d4cfb35d7371941f1c2/src/__tests__/curve.js#L28

image

jacobq commented 6 years ago

Oops, I just noticed that the data referenced here actually isn't the bennet5 data but rather the data used for sigmoid fitting. In any case, I think it deserves some clarification.