search

mljs / levenberg-marquardt

Curve fitting method in JavaScript
MIT License
70 stars 15 forks source link

feat: timeout option to avoid long executions #35

Closed jobo322 closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #35 (967df3f) into master (4ee14d5) will increase coverage by 0.48%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   92.37%   92.85%   +0.48%     
==========================================
  Files           5        5              
  Lines         118      126       +8     
  Branches       34       37       +3     
==========================================
+ Hits          109      117       +8     
  Misses          7        7              
  Partials        2        2
Impacted Files Coverage Δ
src/checkOptions.js 85.71% <100.00%> (+1.40%) :arrow_up:
src/index.js 95.65% <100.00%> (+0.65%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4ee14d5...967df3f. Read the comment docs.

targos commented 3 years ago

I would prefer to have no timeout by default.

jobo322 commented 3 years ago

yes, it is better to pass a default value coming from spectra-fitting or ml-gsd because is there where we have the long executions problem