search

mljs / libsvm

LIBSVM for the browser and nodejs :fire:
https://mljs.github.io/libsvm/
BSD 3-Clause "New" or "Revised" License
82 stars 14 forks source link

refactor: cleanup #20

Open wadjih-bencheikh18 opened 2 years ago

targos commented 2 years ago

do you know why the nodejs workflow isn't running in this PR?

No idea. I verified that actions are enabled for the repo.

targos commented 2 years ago

Btw I would be surprised if everything still works without changes given the huge amount of major dependency upgrades.

wadjih-bencheikh18 commented 2 years ago

No idea. I verified that actions are enabled for the repo.

Going to check what's the problem

stropitek commented 2 years ago

Yes I think the dependencies should not be bumped in this one. There is an ongoing branch which updates some of the deps, so there will be conflicts

https://github.com/mljs/libsvm/tree/upgrade-deps

I'm working on this on my free time but I think that branch can be merged once I find a few hours to finish it.

stropitek commented 2 years ago

Also the tests rely on code that is generated by emscripten, so no chance this will work without a build step first

targos commented 2 years ago

I think we should hold off on this PR. Finish your branch first, then work on this again (emscripten will have to be installed in the workflow somehow)