mljs / matrix

Matrix manipulation and computation library
https://mljs.github.io/matrix/
MIT License
353 stars 54 forks source link

Improve inspect/toString number formatter #157

Closed Dimava closed 1 year ago

Dimava commented 1 year ago

There was a corner case in inspect breaking the proper tabulation,
so I chose to rewrite the whole number formatter in a way I would like to see it to work.

codecov[bot] commented 1 year ago

Codecov Report

Base: 66.67% // Head: 66.80% // Increases project coverage by +0.12% :tada:

Coverage data is based on head (a8e3bcd) compared to base (4b8e9b7). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head a8e3bcd differs from pull request most recent head 3a621e7. Consider uploading reports for the commit 3a621e7 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #157 +/- ## ========================================== + Coverage 66.67% 66.80% +0.12% ========================================== Files 32 32 Lines 3232 3241 +9 Branches 514 520 +6 ========================================== + Hits 2155 2165 +10 + Misses 997 996 -1 Partials 80 80 ``` | [Impacted Files](https://codecov.io/gh/mljs/matrix/pull/157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mljs) | Coverage Δ | | |---|---|---| | [src/inspect.js](https://codecov.io/gh/mljs/matrix/pull/157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mljs#diff-c3JjL2luc3BlY3QuanM=) | `100.00% <100.00%> (+3.03%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mljs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mljs)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.