search

mljs / pls

PLS regression algorithm
http://mljs.github.io/pls/
MIT License
10 stars 5 forks source link

refactor(getSumCol): improving performance of the maxSumColIndex func… #6

Closed JeffersonH44 closed 9 years ago

JeffersonH44 commented 9 years ago

…tion.

targos commented 9 years ago

@JeffersonH44 Can you post the result of the benchmark here for posterity ?

JeffersonH44 commented 9 years ago

v1 x 133,974 ops/sec ±0.22% (97 runs sampled) v2 x 21,856,978 ops/sec ±0.20% (97 runs sampled) v3 x 21,728,375 ops/sec ±0.18% (101 runs sampled)

targos commented 9 years ago

the commit message is too long. you can put "improve performance of maxSumColIndex"

JeffersonH44 commented 9 years ago

Change the version number of npm package

targos commented 9 years ago

LGTM